refactor(match2): grid based view for chess - #7974
Open
Rathoz wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the chess match summary rendering to use the shared grid-based MatchSummaryWidgets.GameRow component, aiming to modernize/standardize the game row layout.
Changes:
- Replaced the custom per-game row renderer with a
GameRowcomponent implementation (createGames+GameRowComponentProps). - Adjusted chess map extra data handling to prefer using
comment(intended as a fallback to the oldheaderfield).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lua/wikis/chess/MatchSummary.lua | Switches chess match summary game rows to the grid-based GameRow component and provides chess-specific overview/opponent view rendering. |
| lua/wikis/chess/MatchGroup/Input/Custom.lua | Changes map extra data extraction to prefer comment (with fallback to header) alongside ECO sanitization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rathoz
force-pushed
the
grid-base-view-chess
branch
from
August 18, 2026 10:46
4630031 to
5ed59c2
Compare
Rathoz
force-pushed
the
grid-base-view-chess
branch
from
August 18, 2026 10:56
5ed59c2 to
61aaf1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor chess to use grid based match summary.
Also remove the header input, some of it will be replaced by Sets (later in the stack) and others will be changed to comments instead.
How did you test this change?
Together with the rest of the stack