Skip to content

refactor(match2): allow passing the GameRow only - #7976

Open
Rathoz wants to merge 2 commits into
grid-base-view-chessfrom
m2-ms-gamerow
Open

refactor(match2): allow passing the GameRow only#7976
Rathoz wants to merge 2 commits into
grid-base-view-chessfrom
m2-ms-gamerow

Conversation

@Rathoz

@Rathoz Rathoz commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

Allow setup to pass only GameRow Widget in Custom Match Summary. Set it up on chess as well.

How did you test this change?

tested together with the 4th PR in the stack

@Rathoz
Rathoz marked this pull request as ready for review August 17, 2026 18:51
@Rathoz
Rathoz requested review from a team as code owners August 17, 2026 18:51
Copilot AI lite review requested due to automatic review settings August 17, 2026 18:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the shared MatchSummary base implementation to support customizing game rendering by providing a GameRow component directly (instead of requiring createGames / createGame), and updates the Chess wiki implementation to use that new hook.

Changes:

  • Extend CustomMatchSummaryInterface and default body rendering to support CustomMatchSummary.GameRow.
  • Refactor the default body builder to render games via GameRow when present (falling back to createGames / createGame).
  • Update lua/wikis/chess/MatchSummary.lua to provide GameRow and remove its custom createGames implementation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lua/wikis/commons/MatchSummary/Base.lua Adds GameRow support and routes default game rendering through it when available.
lua/wikis/chess/MatchSummary.lua Switches Chess match summary customization to provide GameRow instead of createGames.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lua/wikis/commons/MatchSummary/Base.lua Outdated
Comment thread lua/wikis/commons/MatchSummary/Base.lua
Comment thread lua/wikis/chess/MatchSummary.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants