Skip to content

feat(match2): make sets available by default - #7978

Open
Rathoz wants to merge 7 commits into
m2-ms-gamerowfrom
m2-ms-sets
Open

feat(match2): make sets available by default#7978
Rathoz wants to merge 7 commits into
m2-ms-gamerowfrom
m2-ms-sets

Conversation

@Rathoz

@Rathoz Rathoz commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

image

TODO/Followup PR:

  • Bold the set name
  • Game vods should be within the set

How did you test this change?

Tested on chess

@Rathoz
Rathoz marked this pull request as ready for review August 17, 2026 18:51
@Rathoz
Rathoz requested a review from a team as a code owner August 17, 2026 18:51
Copilot AI lite review requested due to automatic review settings August 17, 2026 18:51
@Rathoz
Rathoz requested a review from a team as a code owner August 17, 2026 18:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes “sets” (submatches/subgroups) available by default for match2-based match parsing and rendering, enabling match summaries to group games into sets and show set-level headers/results without requiring wiki-specific opt-ins.

Changes:

  • Always compute match.submatches in MatchGroupUtil.matchFromRecord and always assign map.subgroup during standard map processing.
  • Update multiple wiki MatchSummary/MatchGroup implementations to rely on match.submatches directly (and remove legacy ADD_SUB_GROUP usage).
  • Add a new SetHeader widget (plus SCSS) and integrate it into the default MatchSummary body rendering when GameRow is used.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
stylesheets/commons/Brackets.scss Adds a flex helper class for centering set header content in match summary headers.
lua/wikis/warcraft/MatchSummary.lua Renames off-factions helper and simplifies submatch selection; adjusts return annotations.
lua/wikis/warcraft/MatchGroup/Util/Custom.lua Uses precomputed match.submatches; renames computeOffFactions; adds (but currently incorrect) type annotations.
lua/wikis/warcraft/MatchGroup/Input/Custom.lua Removes ADD_SUB_GROUP from map parser config.
lua/wikis/stormgate/MatchSummary.lua Mirrors warcraft changes: off-factions naming, simplified submatch selection, annotations.
lua/wikis/stormgate/MatchGroup/Util/Custom.lua Uses precomputed match.submatches; adds (currently incorrect) type annotations.
lua/wikis/stormgate/MatchGroup/Input/Custom.lua Removes ADD_SUB_GROUP from map parser config.
lua/wikis/hearthstone/MatchSummary.lua Simplifies team submatch selection logic.
lua/wikis/hearthstone/MatchGroup/Util/Custom.lua Uses precomputed match.submatches; adds (currently incorrect) type annotation.
lua/wikis/hearthstone/MatchGroup/Input/Custom.lua Removes ADD_SUB_GROUP and leaves an empty map parser config table.
lua/wikis/commons/Widget/Match/Summary/SetHeader.lua New widget that computes and renders set-level win/loss indicators and score.
lua/wikis/commons/Widget/Match/Summary/All.lua Exposes the new SetHeader widget via the summary widget bundle.
lua/wikis/commons/MatchSummary/Starcraft.lua Simplifies submatch selection logic; adjusts return annotations.
lua/wikis/commons/MatchSummary/Base.lua Integrates set grouping + set headers into default body rendering when GameRow is provided.
lua/wikis/commons/MatchGroup/Util/Starcraft.lua Uses precomputed match.submatches when constructing submatches.
lua/wikis/commons/MatchGroup/Util.lua Always computes match.submatches in matchFromRecord; documents submatches on the match type.
lua/wikis/commons/MatchGroup/Input/Util.lua Removes ADD_SUB_GROUP concept and always assigns map.subgroup incrementally by default.
lua/wikis/commons/MatchGroup/Input/Starcraft.lua Removes ADD_SUB_GROUP from map parser config.
lua/wikis/clashroyale/MatchGroup/Input/Custom.lua Removes ADD_SUB_GROUP from map parser config.
lua/wikis/chess/MatchSummary.lua Removes stray blank lines (format-only).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lua/wikis/warcraft/MatchGroup/Util/Custom.lua Outdated
Comment thread lua/wikis/commons/MatchSummary/Base.lua
Comment thread lua/wikis/stormgate/MatchGroup/Util/Custom.lua Outdated
Comment thread lua/wikis/hearthstone/MatchGroup/Util/Custom.lua Outdated
Comment thread lua/wikis/commons/MatchSummary/Base.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants