feat(match2): make sets available by default - #7978
Open
Rathoz wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes “sets” (submatches/subgroups) available by default for match2-based match parsing and rendering, enabling match summaries to group games into sets and show set-level headers/results without requiring wiki-specific opt-ins.
Changes:
- Always compute
match.submatchesinMatchGroupUtil.matchFromRecordand always assignmap.subgroupduring standard map processing. - Update multiple wiki MatchSummary/MatchGroup implementations to rely on
match.submatchesdirectly (and remove legacyADD_SUB_GROUPusage). - Add a new
SetHeaderwidget (plus SCSS) and integrate it into the default MatchSummary body rendering whenGameRowis used.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/Brackets.scss | Adds a flex helper class for centering set header content in match summary headers. |
| lua/wikis/warcraft/MatchSummary.lua | Renames off-factions helper and simplifies submatch selection; adjusts return annotations. |
| lua/wikis/warcraft/MatchGroup/Util/Custom.lua | Uses precomputed match.submatches; renames computeOffFactions; adds (but currently incorrect) type annotations. |
| lua/wikis/warcraft/MatchGroup/Input/Custom.lua | Removes ADD_SUB_GROUP from map parser config. |
| lua/wikis/stormgate/MatchSummary.lua | Mirrors warcraft changes: off-factions naming, simplified submatch selection, annotations. |
| lua/wikis/stormgate/MatchGroup/Util/Custom.lua | Uses precomputed match.submatches; adds (currently incorrect) type annotations. |
| lua/wikis/stormgate/MatchGroup/Input/Custom.lua | Removes ADD_SUB_GROUP from map parser config. |
| lua/wikis/hearthstone/MatchSummary.lua | Simplifies team submatch selection logic. |
| lua/wikis/hearthstone/MatchGroup/Util/Custom.lua | Uses precomputed match.submatches; adds (currently incorrect) type annotation. |
| lua/wikis/hearthstone/MatchGroup/Input/Custom.lua | Removes ADD_SUB_GROUP and leaves an empty map parser config table. |
| lua/wikis/commons/Widget/Match/Summary/SetHeader.lua | New widget that computes and renders set-level win/loss indicators and score. |
| lua/wikis/commons/Widget/Match/Summary/All.lua | Exposes the new SetHeader widget via the summary widget bundle. |
| lua/wikis/commons/MatchSummary/Starcraft.lua | Simplifies submatch selection logic; adjusts return annotations. |
| lua/wikis/commons/MatchSummary/Base.lua | Integrates set grouping + set headers into default body rendering when GameRow is provided. |
| lua/wikis/commons/MatchGroup/Util/Starcraft.lua | Uses precomputed match.submatches when constructing submatches. |
| lua/wikis/commons/MatchGroup/Util.lua | Always computes match.submatches in matchFromRecord; documents submatches on the match type. |
| lua/wikis/commons/MatchGroup/Input/Util.lua | Removes ADD_SUB_GROUP concept and always assigns map.subgroup incrementally by default. |
| lua/wikis/commons/MatchGroup/Input/Starcraft.lua | Removes ADD_SUB_GROUP from map parser config. |
| lua/wikis/clashroyale/MatchGroup/Input/Custom.lua | Removes ADD_SUB_GROUP from map parser config. |
| lua/wikis/chess/MatchSummary.lua | Removes stray blank lines (format-only). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hjpalpha
reviewed
Aug 18, 2026
hjpalpha
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO/Followup PR:
How did you test this change?
Tested on chess