Skip to content

fix(match2): Literals not displayed in brackets #7983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjpalpha wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix(match2): Literals not displayed in brackets #7983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef7844c
Update OpponentEntry.lua
hjpalpha Aug 18, 2026
39aa53d
Update Starcraft.lua
hjpalpha Aug 18, 2026
3883c50
Delete lua/wikis/commons/Widget/Match/Bracket/Opponent/Starcraft.lua
hjpalpha Aug 18, 2026
5c4a095
Update Starcraft.lua
hjpalpha Aug 18, 2026
116367c
Update OpponentEntry.lua
hjpalpha Aug 18, 2026
b840eb2
Update Block.lua
hjpalpha Aug 18, 2026
de64167
Update OpponentDisplay.lua
hjpalpha Aug 18, 2026
c4a1f0a
Update Character.lua
hjpalpha Aug 18, 2026
32e60ce
Update Opponent.lua
hjpalpha Aug 18, 2026
54f33c9
Update Opponent.lua
hjpalpha Aug 18, 2026
e0a5b31
Update Starcraft.lua
hjpalpha Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lua/wikis/commons/OpponentDisplay.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
-- @Liquipedia
-- page=Module:OpponentDisplay
Expand Down Expand Up @@ -97,7 +97,6 @@
---@field showFlag boolean?
---@field showLink boolean?
---@field showPlayerTeam boolean?
---@field playerClass string?
---@field teamStyle teamStyle?
---@field dq boolean?
---@field note string|number|nil
Expand Down
5 changes: 3 additions & 2 deletions lua/wikis/commons/Widget/Match/Bracket/Opponent.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
-- @Liquipedia
-- page=Module:Widget/Match/Bracket/Opponent
Expand All @@ -7,7 +7,8 @@

local Lua = require('Module:Lua')

local OpponentDisplay = Lua.import('Module:OpponentDisplay')
local Opponent = Lua.import('Module:Opponent/Custom')
local OpponentDisplay = Lua.import('Module:OpponentDisplay/Custom')

local Component = Lua.import('Module:Widget/Component')

Expand All @@ -24,7 +25,7 @@
opponent = opponent,
overflow = 'ellipsis',
showLink = false,
showTbd = props.showTbd,
showTbd = opponent.type == Opponent.literal or props.showTbd,
Comment thread
Rathoz marked this conversation as resolved.
teamStyle = props.forceShortName and 'short' or 'dynamic',
}
end
Expand Down
32 changes: 0 additions & 32 deletions lua/wikis/commons/Widget/Match/Bracket/Opponent/Starcraft.lua
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions lua/wikis/commons/Widget/Match/Bracket/OpponentEntry/Starcraft.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
-- @Liquipedia
-- page=Module:Widget/Match/Bracket/OpponentEntry/Starcraft
Expand All @@ -11,7 +11,6 @@

local Component = Lua.import('Module:Widget/Component')
local BracketOpponentEntry = Lua.import('Module:Widget/Match/Bracket/OpponentEntry')
local StarcraftBracketOpponent = Lua.import('Module:Widget/Match/Bracket/Opponent/Starcraft')

---@class StarcraftBracketOpponentEntryProps: BracketOpponentEntryProps
---@field opponent StarcraftStandardOpponent
Expand All @@ -20,7 +19,6 @@
---@return VNode
local function StarcraftBracketOpponentEntry(props)
local opponent = props.opponent
props.BracketOpponent = StarcraftBracketOpponent
props.showFactionBackground = opponent.type == Opponent.solo
or opponent.type == Opponent.duo and opponent.isArchon
return BracketOpponentEntry(props)
Expand Down
4 changes: 0 additions & 4 deletions lua/wikis/commons/Widget/PlayerDisplay/Block.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
-- @Liquipedia
-- page=Module:Widget/PlayerDisplay/Block
Expand All @@ -18,7 +18,6 @@
local WidgetUtil = Lua.import('Module:Widget/Util')

---@class BlockPlayerDisplayProps: InlinePlayerDisplayProps
---@field playerClass string|string[]?
---@field overflow OverflowModes?
---@field showPlayerTeam boolean?
---@field note Renderable|Renderable[]?
Expand All @@ -28,12 +27,9 @@
local function BlockPlayer(props)
local player = props.player
local factionDisplay = PlayerDisplayComponents.faction(props)
local playerClasses = type(props.playerClass) == 'string' and
{props.playerClass} or props.playerClass --[[ @as string[]? ]]
local useDefault = Logic.nilOr(Logic.readBoolOrNil(props.showTbd), true) or not Opponent.playerIsTbd(player)
local showPlayerTeam = props.showPlayerTeam
return BlockWrapper{
classes = playerClasses,
flip = props.flip,
showPlayerTeam = showPlayerTeam,
children = WidgetUtil.collect(
Expand Down
3 changes: 0 additions & 3 deletions lua/wikis/commons/Widget/PlayerDisplay/Block/Character.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
---
-- @Liquipedia
-- page=Module:Widget/PlayerDisplay/Block/Character
Expand Down Expand Up @@ -45,12 +45,9 @@
local function BlockCharacterPlayer(props)
local player = props.player
local charactersDisplay = getCharacters(player)
local playerClasses = type(props.playerClass) == 'string' and
{props.playerClass} or props.playerClass --[[ @as string[]? ]]
local useDefault = Logic.nilOr(Logic.readBoolOrNil(props.showTbd), true) or not Opponent.playerIsTbd(player)
local showPlayerTeam = props.showPlayerTeam
local block = BlockWrapper{
classes = playerClasses,
flip = props.flip,
showPlayerTeam = showPlayerTeam,
children = WidgetUtil.collect(
Expand Down
Loading