Skip to content

feat: prep some stuff for lighthouse forms multiselect - #7987

Open
hjpalpha wants to merge 6 commits into
mainfrom
parse-multiselect
Open

feat: prep some stuff for lighthouse forms multiselect#7987
hjpalpha wants to merge 6 commits into
mainfrom
parse-multiselect

Conversation

@hjpalpha

@hjpalpha hjpalpha commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

currently forms pass a csv value when using input type=checkboxes
with the new lighthouse forms that option will be converted to multiselect
multiselect will pass json instead of csv to the modules
hence add a functio for parsing both and adjust a few modules that are used by forms on sc2 with input type=checkboxes so that they do not break with LH conversion

After merge

  • Adjust the following non git modules on sc2 too:
    • Module:PlayerStatistics
    • Module:HeadToHead
  • check open PRs for needed adjusts

How did you test this change?

dev

@hjpalpha
hjpalpha marked this pull request as ready for review August 19, 2026 16:01
@hjpalpha
hjpalpha requested review from a team as code owners August 19, 2026 16:01

@ElectricalBoy ElectricalBoy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put Array.parseMultiSelect under Module:Forms/Util or something where we could potentially add form-related helper functions? I'm just thinking out loud

Comment thread lua/wikis/commons/Array.lua Outdated
@hjpalpha

Copy link
Copy Markdown
Collaborator Author

maybe put Array.parseMultiSelect under Module:Forms/Util or something where we could potentially add form-related helper functions? I'm just thinking out loud

fwiw not sure on the name and also not sure on putting it into array
was just the first thing that came to mind

regarding Module:Forms/Util
i thought about something like that, but discarded it because its usage is not really related to forms
like the modules the forms use aren't only used in those forms but also in other places
so to me it feels wrong to use formUtils in modules that are primarily not used in forms

@hjpalpha
hjpalpha requested a review from ElectricalBoy August 20, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants