fix(match2): remove the usage of bans extradata on brawlstars - #8001
Open
steve020607 wants to merge 8 commits into
Open
fix(match2): remove the usage of bans extradata on brawlstars#8001steve020607 wants to merge 8 commits into
steve020607 wants to merge 8 commits into
Conversation
was previously changed to use teamXbanY, and bans get removed This commit changed the way that the MatchSummary will take the ban and use the MatchSummary/Base function that are already exist
steve020607
changed the title
hjpalpha
approved these changes
Aug 23, 2026
Rathoz
approved these changes
Aug 24, 2026
Member
|
Does the input side need updating too? |
Collaborator
Author
What input side? doesn't understand that |
Collaborator
https://discord.com/channels/93055209017729024/372075546231832576/1541696215312375859
looks like this has a bug |
Helped by claude code
Collaborator
Author
got fixed on recent commit |
hjpalpha
reviewed
Aug 25, 2026
hjpalpha
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://discord.com/channels/93055209017729024/591393837927366672/1541029588728160368
reported bug, cause by #7911 changes and miss this module
How did you test this change?
Dev
https://liquipedia.net/brawlstars/Module:MatchSummary/dev/steve23