Conversation
This was referenced Aug 29, 2026
ero-qt
force-pushed
the
managed-readers
branch
4 times, most recently
from
September 14, 2026 17:17
2e157c3 to
267a8b9
Compare
ero-qt
force-pushed
the
managed-readers
branch
from
September 15, 2026 11:02
267a8b9 to
45b7f09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #149.
Adds
read_stringandread_arrayto both backends'Module. Without them, reading aSystem.Stringor a managed array is a fixed-size read at a memorized header offset, unchecked against the count and wrong at the other pointer width.read_stringreads the character count, then exactly that many UTF-16 characters. A count past the buffer, a negative count, and a null reference fail rather than truncate.read_arraydoes the same with the length, judged at pointer width before narrowing so a huge value cannot slip through as its low half. The element type is the caller's claim, likeProcess::read. Managedcharisu16, and Rustcharnever matches.Both take the address the reference is stored at and dereference at the module's own width, so 32-bit games need no special handling.
ArrayVecappears in a public signature for the first time. The crate already re-exportsarrayvec.cargo test --all-featuresruns the suite. The new tests cover strings and arrays on both runtimes, counts past the buffer, lengths at full width, and 32-bit targets.Depends on #146.