Add hashset reads - #151
Merged
Merged
Conversation
This was referenced Aug 29, 2026
ero-qt
force-pushed
the
hashset-reader
branch
12 times, most recently
from
September 17, 2026 14:41
de8b12d to
f8c431d
Compare
Collaborator
|
I’m waiting for this PR to be rebased onto the current master before continuing the review. It currently still contains the PR #150 commits in its history and GitHub reports conflicts. Please let me know once it has been rebased. |
Contributor
Author
|
Rebased. It's on master now with just its own commit, and I folded the same class hierarchy check and the empty case in for hash sets while I was at it. |
ero-qt
force-pushed
the
hashset-reader
branch
from
September 17, 2026 16:53
f8c431d to
0318baa
Compare
CryZe
approved these changes
Sep 17, 2026
CryZe
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the public API, implementation, and tests. Also validated the IL2CPP path against Lunistice with a live HashSet, including the canonical empty/unallocated representation; offset and slot layout resolution and the read all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #149.
Adds
get_hash_set_offsetsandread_hash_setto both backends'Module, built on the dictionary machinery. A slot is a dictionary entry without the key, so resolution and the chunked scan are the same code handed different names.Resolution accepts both corlib naming generations. The set's bucket heads are one-based in both generations, unlike the dictionary's. Nothing reads buckets yet, but whoever adds keyed lookups will want that written down.
read_hash_setwalks to_lastIndex, the high-water mark, since freed slots sit inside it. The live tally has to equal_countexactly or the read fails. The value type is the caller's claim, refused past the slot's room.cargo test --all-featuresruns the suite. The new tests cover both naming generations, live values on both runtimes, and unbalanced tallies.