Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #141.
Replaces the IL2CPP version tables with a lookup over the measured builds, so every game attaches through the build nearest to its Unity version. The key is all four parts of
UnityPlayer.dll's file version plus the width. A measured version gets its own entry. Any other version gets the newest entry whose major.minor is at or below its own, or the oldest entry when nothing is below. The metadata version is no longer part of the key, so attach no longer waits forglobal-metadata.dat.Version,attach(process, Version)andwait_attach(process, Version)are gone with the tables.attach_auto_detectandwait_attach_auto_detectstay as they were.Versionmatch in the class walk decided before. The 2018.4 through 2020.1 PDBs haveIl2CppImage::typeStart, the later onesmetadataHandle.cargo test --all-featuresruns the suite. The new tests cover the lookup rule across versions and widths,attach_auto_detectfor an unmeasured player, the class walk on both type start shapes, and images at 32 bit through a measured x86 entry.