Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
WidgetKind::Buttonanduser_settings_add_buttonso autosplitters can have action buttons in the settings UI.Hosts invoke clicks with
invoke_settings_button(key).The optional no-arg
on_settings_buttonexport should pull the key to match to a button viauser_settings_get_button_key- this was intended to be the same buffer protocol as other implementations in this repo (likeruntime_get_os). The alternative was for the host to write directly into guest memory to provide the key, but this added a fair amount of complexity that didn't align with existing patterns so I decided against it.Related PRs to enable this functionality across the ecosystem: