Skip to content

build(windows): default to qt6-static - #5497

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/windows/default-to-qt6-static
Aug 11, 2026
Merged

build(windows): default to qt6-static#5497
ReenigneArcher merged 1 commit into
masterfrom
build/windows/default-to-qt6-static

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Changes default Windows build to match CI. Dynamic version can specified manually though.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Last Updated 2026-08-11 15:27:53 UTC
Source Run CI Run #4931
Commit cd22b704e02e80e9299f9a767960c8b94a6b261e

Screenshot Comparison

PR #5497 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.10%. Comparing base (3cba9ba) to head (cd22b70).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5497      +/-   ##
==========================================
+ Coverage   26.81%   28.10%   +1.28%     
==========================================
  Files         109      109              
  Lines       24580    24711     +131     
  Branches    10788    10911     +123     
==========================================
+ Hits         6592     6944     +352     
- Misses      14745    16769    +2024     
+ Partials     3243      998    -2245     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.98% <ø> (+<0.01%) ⬆️
Homebrew-macos-14 22.55% <ø> (ø)
Homebrew-macos-15 23.21% <ø> (+<0.01%) ⬆️
Homebrew-macos-26 23.32% <ø> (-0.01%) ⬇️
Homebrew-ubuntu-24.04 14.01% <ø> (ø)
Linux-AppImage 13.42% <ø> (ø)
Windows-AMD64 17.42% <ø> (ø)
Windows-ARM64 14.98% <ø> (-0.01%) ⬇️
macOS-arm64 19.81% <ø> (?)
macOS-x86_64 20.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 72 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cba9ba...cd22b70. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the build/windows/default-to-qt6-static branch from 849be19 to cd22b70 Compare August 11, 2026 14:29
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher merged commit cf52f4b into master Aug 11, 2026
69 of 70 checks passed
@ReenigneArcher
ReenigneArcher deleted the build/windows/default-to-qt6-static branch August 11, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant