Profile update test - #53
Open
harshil15999 wants to merge 2 commits into
Open
Conversation
Updating my fork
I have written the test for user profile please check it and tell me my mistakes. I did not know how to run it as I havent understood how the person in the codebase is sending which response on updating user profile
|
Thanks @harshil15999, for opening the pull request! 🙌 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 67.67% 67.67%
=======================================
Files 7 7
Lines 99 99
Branches 5 5
=======================================
Hits 67 67
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
YashKumarVerma
requested changes
Jun 18, 2020
| password:'123', | ||
| teams:['2','3'] | ||
| } | ||
| chai.request('http://localhost:3000') |
Member
There was a problem hiding this comment.
not the correct way. check sample code repo
YashKumarVerma
requested changes
Jun 19, 2020
| .send(update) | ||
| .end((err,res)=>{ | ||
| res.should.have.status(200); | ||
| res.body.should.be.json; |
Member
There was a problem hiding this comment.
check responses individually, like expect the response to contain new data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the code and revert back .
Few doubts
Resolves #42