Conversation
Model: gpt-5.6-sol Signed-off-by: Dante <duanjl.china@gmail.com>
Dante-dan
force-pushed
the
fix/188-imported-custom-session-launch
branch
from
September 14, 2026 08:02
50c547b to
d618845
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #188
Problem / pressure
An imported custom ACP session records its provider identity but legitimately has no
agentConfigId. The resume path therefore returned without consulting the target machine's current agent configurations and failed withsession_restore_failed, even when exactly one machine-owned configuration could safely supply the custom launch command.Summary
agentConfigfamily only for externally imported custom sessions without an explicit config id.machineId,cliType, andagentType, accepting exactly one current configuration and failing closed for zero or multiple matches.Visual explanation
flowchart TD A[Resume imported session] --> B{Explicit agentConfigId?} B -- Yes --> C[Existing exact-id resolution] B -- No --> D{external-acp + custom?} D -- No --> E[Existing legacy or provider resolution] D -- Yes --> F[Read target-machine agentConfig family] F --> G{Matches machineId + cliType + agentType} G -- Exactly one --> H[Use current machine-owned launch fields] G -- Zero or multiple --> I[Remain unresolved; restore reports failure]Before / after
agentConfigIdnever consulted current machine configuration.customAcp, environment, and runtime overrides; missing or ambiguous matches still fail closed.Test plan
pnpm --filter lody exec vitest run src/session/session-launch-config-resolver.test.ts— 7/7 passed.pnpm format— passed for the submitted files.git diff --check— passed.Context handoff
This handoff is public. An invalid external PR receives a seven-day correction period before closure.
Instructions for reviewing agents
session-launch-config-resolver.tsfor target-machine authority, unique-match semantics, and preservation of explicit-id and legacy paths.machineId,cliType, andagentTypeis sufficient and that ambiguity should fail closed instead of selecting by ordering.Authoring context
Original user prompt
Show original prompt