Conversation
This was referenced Sep 14, 2026
zxch3n
added this pull request to stack #713
September 14, 2026 17:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / pressure
Attachment transfers and send-path store borrows outlive individual composer mounts, but previously had no shared workspace owner. Image removal did not cancel XHR, and multipart failure cleanup could outlive its caller.
Summary
Stack 2/4, based on #705. Add an internal Effect resource owner with a Promise-facing interface. Landing and continuation file preparation share one pipeline; image uploads forward cancellation to XHR. Workspace shutdown interrupts all owned work and waits for raw IPC and cleanup before releasing its dependencies. Store borrows return references through the existing cache.
Transfer still starts when attachments are added. Persistent submission/recovery and complete draft UX are the next two layers; upload-free local references remain separate.
Visual explanation
Before / after
Test plan
TMPDIR=/private/tmp NODE_ENV=test pnpm checkpasses completely, including 478 component files / 3,661 tests.pnpm formatandpnpm run docs checkcompleted (zero documentation errors). No packaged-device draft acceptance claimed.Context handoff
Instructions for reviewing agents
session-send-resources.ts, the shared file preparation adapter, and workspace disposal order.Authoring context