fix(components): use a touch slider for conversation font size - #723
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: 🟢 low | Confidence: high — isolated appearance control; covered by component tests and browser touch/keyboard checks.
Problem / pressure
Adjusting conversation text size on a phone should be a direct touch interaction. The existing size picker requires opening a menu for each adjustment.
Summary
Visual explanation
Phone screenshots were shared in the task conversation.
Before / after
Test plan
/varversus/private/varpath assertion failure; its 11-test suite passed withTMPDIR=/private/tmp. All other CLI tests passed. The interrupted remainder was run separately: Electron (112 tests), i18n, import/platform/public-boundary guards all passed.scripts/format-check-changed.mjs), so the public repository's full check was used.Context handoff
Instructions for reviewing agents
CONVERSATION_FONT_SIZES; storage and sample rendering must receive pixel values.