feat(ds4): run CUDA and HIP expert parallelism in one process - #570
Draft
davide221 wants to merge 3 commits into
Draft
feat(ds4): run CUDA and HIP expert parallelism in one process#570davide221 wants to merge 3 commits into
davide221 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all_logits_outallocates and returns every token's logitsLucebox2 results
Strix Halo 128 GiB + RTX 3090 24 GiB, target on HIP, four complete expert layers and DSpark on CUDA, q=2:
This remains a draft because mixed expert parallelism is still slower than the no-split control. CUDA/HIP activations currently use in-process host staging; a safe asynchronous transfer-stream/event bridge is still needed for a material speedup. CUDA-primary ROCmFP2 target execution is not qualified.
Latest validation
66b226b3a(fix(ds4): retain all verifier logits in eager path)mixed_cuda_hip,deepseek4_unit, andmoe_routing_stats_suitepassedReverted experiment — not in this PR
An experimental destination-sync-elision staging path was byte-identical on its first matched run but regressed to 12.4 tok/s. Its warm repeat coincided with NVIDIA Xid 79 on the test 3090. The experiment was fully reverted before
66b226b3a; the branch contains neither its scheduler changes nor its environment flag.Do not reintroduce that shortcut. The next implementation must use explicit vendor-local transfer streams, pinned host staging, and correctly owned completion events.
Merge status
Keep as draft. The code is useful foundational mixed-runtime support, but it is not yet a production performance win on the tested 3090 + Strix Halo system.