fix: split funding_events and slab_deletion_queue migrations - #17
Merged
Conversation
…tions Slab_deletion_queue was bundled into the same migration function as the funding_events ALTER TABLE. Split them so slab_deletion_queue matches upstream's migration index, with the funding_events ALTER as a separate migration appended after.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
funding_eventsALTER TABLE andCREATE TABLE slab_deletion_queueinto two separate migration functionsslab_deletion_queuenow matches upstream's migration index; thefunding_eventsALTER is a separate migration appended afterThis PR splits a combined database migration into two separate migration steps. Previously, the
funding_eventstable alterations (addingfund_typeandpool_idcolumns with their indexes) and theslab_deletion_queuetable creation were executed together in a single migration function. They are now separated into distinct migration functions, with theslab_deletion_queuetable creation running first, followed by thefunding_eventscolumn and index additions. This separation ensures each schema change is applied as an individual migration step, improving migration reliability and rollback granularity.