-
Notifications
You must be signed in to change notification settings - Fork 0
Fix idle CPU usage and cap long-running stream buffers #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { describe, it, expect } from 'vitest' | ||
| import { appendStreamContent } from '@/utils/streaming' | ||
|
|
||
| const KB = 1024 | ||
|
|
||
| describe('appendStreamContent', () => { | ||
| it('appends without trimming while under the limit', () => { | ||
| const result = appendStreamContent('abc', 'def', 1) | ||
| expect(result.content).toBe('abcdef') | ||
| expect(result.droppedChars).toBe(0) | ||
| }) | ||
|
|
||
| it('treats a limit of 0 as unlimited', () => { | ||
| const previous = 'x'.repeat(5 * KB) | ||
| const result = appendStreamContent(previous, 'y'.repeat(5 * KB), 0) | ||
| expect(result.content).toHaveLength(10 * KB) | ||
| expect(result.droppedChars).toBe(0) | ||
| }) | ||
|
|
||
| it('treats a negative limit as unlimited', () => { | ||
| const result = appendStreamContent('x'.repeat(4 * KB), 'y', -1) | ||
| expect(result.droppedChars).toBe(0) | ||
| }) | ||
|
|
||
| it('keeps the buffer bounded at the limit', () => { | ||
| const result = appendStreamContent('a'.repeat(3 * KB), 'b'.repeat(1 * KB), 2) | ||
| expect(result.content.length).toBeLessThanOrEqual(2 * KB) | ||
| expect(result.droppedChars).toBe(2 * KB) | ||
| }) | ||
|
|
||
| it('retains the most recent output, not the oldest', () => { | ||
| const result = appendStreamContent('old'.repeat(KB), 'NEWEST', 1) | ||
| expect(result.content.endsWith('NEWEST')).toBe(true) | ||
| }) | ||
|
|
||
| it('cuts at a line break so the first visible line is whole', () => { | ||
| // 2KB of numbered lines, capped to 1KB: the retained text must start | ||
| // cleanly at a line boundary rather than mid-line. | ||
| const lines = Array.from({ length: 300 }, (_, i) => `line-${i}`).join('\n') | ||
| const result = appendStreamContent(lines, '\nlast', 1) | ||
| expect(result.content.startsWith('line-')).toBe(true) | ||
| }) | ||
|
|
||
| it('does not hunt for a line break beyond the alignment window', () => { | ||
| // No newline anywhere in range, so the cut lands exactly on the limit. | ||
| const result = appendStreamContent('z'.repeat(8 * KB), '', 2) | ||
| expect(result.content).toHaveLength(2 * KB) | ||
| expect(result.droppedChars).toBe(6 * KB) | ||
| }) | ||
|
|
||
| it('stays bounded across many successive appends', () => { | ||
| let content = '' | ||
| let dropped = 0 | ||
| for (let i = 0; i < 500; i++) { | ||
| const next = appendStreamContent(content, `chunk ${i} payload\n`, 4) | ||
| content = next.content | ||
| dropped += next.droppedChars | ||
| } | ||
| expect(content.length).toBeLessThanOrEqual(4 * KB) | ||
| expect(dropped).toBeGreaterThan(0) | ||
| expect(content.endsWith('chunk 499 payload\n')).toBe(true) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.