Skip to content

Suggestions UI - #364

Draft
matt-bernhardt wants to merge 2 commits into
mainfrom
tco-145
Draft

matt-bernhardt wants to merge 2 commits into
mainfrom
tco-145

Conversation

@matt-bernhardt

Copy link
Copy Markdown
Member

Summary of changes (please refer to commit messages for full details)

Developer

Ticket(s)

https://mitlibraries.atlassian.net/browse/TCO145

Accessibility

  • ANDI or Wave has been run in accordance to our guide and
    all issues introduced by these changes have been resolved or opened
    as new issues (link to those issues in the Pull Request details above)
  • There are no accessibility implications to this change

Documentation

  • Project documentation has been updated, and yard output previewed
  • No documentation changes are needed

ENV

  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.

Stakeholders

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies and migrations

YES | NO dependencies are updated

YES | NO migrations are included

Reviewer

Code

  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.

Documentation

  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.

Testing

  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@qltysh

qltysh Bot commented Sep 18, 2026

Copy link
Copy Markdown

❌ 2 blocking issues (2 total)

Tool Category Rule Count
rubocop Lint Assignment Branch Condition size for initialize is too high. [<0, 18, 3> 18.25/18] 1
rubocop Lint Method has too many lines. [17/16] 1

Comment thread app/models/ability.rb
Comment thread app/models/ability.rb Outdated
Comment thread test/integration/nav_test.rb
Comment thread test/models/user_test.rb Outdated
Comment thread test/models/user_test.rb Outdated
New integration tests for navigation

This would need to be expanded for other nav elements during maintenance.
Comment thread app/models/ability.rb
return unless user.admin?

can :confirm_uncategorized, Term
can :manage, :all

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Assignment Branch Condition size for initialize is too high. [<0, 18, 3> 18.25/18] [rubocop:Metrics/AbcSize]


2. Method has too many lines. [17/16] [rubocop:Metrics/MethodLength]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants