Skip to content

Add missing validations to the Hold model #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jazairi merged 2 commits into from
Jul 30, 2026
Merged

Add missing validations to the Hold model #1520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9493c
Add missing validations to the Hold model
jazairi Jul 29, 2026
8bd2960
Add regression coverage for missing validations
jazairi Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/hold.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ class Hold < ApplicationRecord
validates :date_requested, presence: true
validates :date_start, presence: true
validates :date_end, presence: true
validates :hold_source, presence: true
validates :status, presence: true
validates :thesis, presence: true

after_save :update_thesis_status

Expand Down
18 changes: 18 additions & 0 deletions test/models/hold_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,24 @@ class HoldTest < ActiveSupport::TestCase
assert(hold.invalid?)
end

test 'invalid without thesis' do
hold = holds(:valid)
assert hold.thesis.present?
assert hold.valid?

hold.thesis = nil
assert_not hold.valid?
end

test 'invalid without hold source' do
hold = holds(:valid)
assert hold.hold_source.present?
assert hold.valid?

hold.hold_source = nil
assert_not hold.valid?
end

test 'valid date_start' do
hold = holds(:valid)
assert(hold.valid?)
Expand Down