Add Alpaka backend support for HardSigmoid, HardSwish, and Softplus - #13
Open
AdityaDRathore wants to merge 3 commits into
Open
Add Alpaka backend support for HardSigmoid, HardSwish, and Softplus#13AdityaDRathore wants to merge 3 commits into
AdityaDRathore wants to merge 3 commits into
Conversation
sanjibansg
requested changes
Jul 21, 2026
sanjibansg
left a comment
sanjibansg
left a comment
Member
There was a problem hiding this comment.
Thanks for this implementation. Could you also add some tests to validate the operators, suited to the alpaka library usage.
AdityaDRathore
force-pushed
the
feature/hardsigmoid-hardwish-softplus-op
branch
from
August 5, 2026 08:44
9da33ce to
2feae8b
Compare
Author
|
Hi @sanjibansg, I have updated the PR with heterogeneous implementation for all three operators (Hardsgmoid, Hardswish, Softplus). While doing this, I found a few issues during the implementation, so to keep this PR clean I have created issues for them. #46 #47 |
AdityaDRathore
force-pushed
the
feature/hardsigmoid-hardwish-softplus-op
branch
from
August 5, 2026 09:45
2feae8b to
4f5c0c7
Compare
AdityaDRathore
changed the title
sanjibansg
requested changes
Aug 10, 2026
sanjibansg
left a comment
sanjibansg
left a comment
Member
There was a problem hiding this comment.
Hi @AdityaDRathore,
Thanks for the changes, can you fix the cmake errors listed below? So, that we can go ahead with the unit testing?
Comment on lines
+24
to
+25
| ROperator_HardSigmoid.hxx | ||
| ROperator_HardSwish.hxx |
Member
There was a problem hiding this comment.
Suggested change
| ROperator_HardSigmoid.hxx | |
| ROperator_HardSwish.hxx | |
| SOFIE/ROperator_HardSigmoid.hxx | |
| SOFIE/ROperator_HardSwish.hxx |
Comment on lines
+36
to
+37
| ParseHardSigmoid.cxx | ||
| ParseHardSwish.cxx |
Member
There was a problem hiding this comment.
Suggested change
| ParseHardSigmoid.cxx | |
| ParseHardSwish.cxx | |
| src/ParseHardSigmoid.cxx | |
| src/ParseHardSwish.cxx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds the Alpaka GPU implementations for hardsigmoid, hardswish and Softplus operators.