[tests] remove cuda/hip test duplication with a templated fixture - #13
Open
harz05 wants to merge 2 commits into
Open
[tests] remove cuda/hip test duplication with a templated fixture#13harz05 wants to merge 2 commits into
harz05 wants to merge 2 commits into
Conversation
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #12
The CUDA and HIP test functions were verbatim, differing only in the platform/device/tag types and the name prefix. The approach used to remove duplication is by using a template file
tests/gpu_tests.tppthat is parameterised with the alpaka tag.Platform and device types come from the tag through
TagToAcc, Dev, Platformand main() instantiates it once per enabledbackend
Changes made to tests/CMakeLists.txt file:
set(... 86), which shadows the cache entry so-Dwas ignored. Defaults tonativebehindif(NOT DEFINED)now.CMAKE_HIP_ARCHITECTURESwas pinned togfx1100. Left unset so CMake takes it fromrocm_agent_enumerator.check_languagewithtest_cudaguarded, same as HIP already did./usr/lib64for RHEL family.test_hipneeds${CMAKE_CURRENT_SOURCE_DIR}on its include path, it compiles a copy oftest.ccfrom the build dir so the include of the .tpp would not resolve otherwise.Testing
No architecture or backend flags needed, cmake picks up whatever is on the machine:
Ran this on two machines:
Results screenshot in the comments below