perf: whole-file range read for DELETE tombstone markers - #373
Merged
Conversation
TombstoneRecords now reads the whole (<=32MB) file once for batches of >=64 markers and resolves each record length from the buffer instead of one pread per offset; the per-marker pread dominated the DELETE commit in profiling (~50ms/10K). Per-offset reads remain the fallback for larger files/small batches. Measured (Release, comparative DELETE 10K of ~100K rows, median of 3): SQL ~53K -> ~57K ops/s, Direct ~69K -> ~87K ops/s.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wat\nTombstoneRecords leest het hele (<=32MB) .dat een keer voor batches van >=64 markers en resolvet elke recordlengte uit het buffer i.p.v. een pread per offset (per-marker pread domineerde de commit in profiling: ~50ms/10K). Per-offset reads blijven fallback voor grotere bestanden/kleine batches.\n\n## Meting (Release, DELETE 10K van ~100K rijen; median van 3)\nSQL ~53K -> ~57K ops/s; Direct ~69K -> ~87K ops/s.\n\n## Validatie\nFull suite (Debug) + Release/CI-filter op alle vier de suites: EXIT=0.