fix(config): Auto engine selection must not land on PageBased (production hardening) - #383
Merged
Merged
Conversation
…ing) With default config (StorageEngineType.Auto + WorkloadHint.General), GetOptimalStorageEngine returned PageBased. The PageBased engine is not yet OLTP-ready (measured UPDATE ~26K ops/s vs ~245K ops/s on the fixed-width Columnar path), so every default-created database risked ending up on the slow engine wherever Auto selection is honored. Auto now routes General / WriteHeavy / unknown hints to AppendOnly/Columnar; PageBased stays reachable only through an explicit StorageEngineType.PageBased until its UPDATE/DELETE fast paths reach parity. Regression: DefaultEngineSelectionTests assert (1) the mapping itself and (2) that a DEFAULT database creates a Columnar fixed-width PK table that engages the single-pass contiguous DELETE fast path and leaves no .pages artifacts. Full suite 1768 tests, 0 failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samenvatting
Production hardening:
Auto-engine-selectie mag niet op PageBased landen.Met default-configuratie (
StorageEngineType.Auto+WorkloadHint.General) gafGetOptimalStorageEngine()PageBased terug. De PageBased-engine is niet OLTP-rijp (gemetenUPDATE ~26K ops/s vs ~245K ops/s op het fixed-width Columnar-pad), dus elke default-database liep
risico op het trage engine-pad zodra ergens Auto-selectie gehonoreerd wordt.
Fix:
StorageEngineType.PageBased(opt-in) tot deUPDATE/DELETE-fast paths parity halen.
Regressie (
DefaultEngineSelectionTests)new DatabaseConfig().GetOptimalStorageEngine() == AppendOnly; expliciete PageBasedopt-in blijft PageBased.
StorageMode.Columnar,IsFixedWidthRecords=true, engineAppendOnly), DELETE van 500 oplopende rijen engageert desingle-pass contiguous fast path (
BulkContiguousDeleteBatches == 1) en er ontstaan géén.pages-artefacten.Validatie