fix(storage): reopen data-integrity fixes for 2.0.0.2 - #390
Merged
Conversation
- directory .ovf reload: zero-length arena records are valid; keep scanning so rows after empty TEXT/BLOB values are not silently dropped on reopen (found via SharpCoreDB.CQRS outbox integration tests) - single-file (.scdb) fixed-width overflow arena: freed slots persist as negative-length tombstone markers tracked across sessions; zero-filled dead gaps misaligned the sequential loader and dropped later values on reopen - legacy variable-length columnar DELETE: purge every remaining record of a deleted key at delete time so older stale UPDATE versions cannot win the reopen index rebuild and resurrect the row (1.x upgrade path) - tests: empty-value reopen regressions, 4-variant reopen round-trip matrix, legacy delete-after-update regression; docs: CHANGELOG [2.0.0.2] Fixed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three data-integrity fixes found by a reopen round-trip hardening sweep (all silent-data-loss class: valid writer output treated as end-of-data / resurrected on reopen):
.ovfreload: zero-length arena records (empty TEXT/BLOB) were treated as end-of-file; later rows/blocks were never loaded after reopen. Fixed inStorage.ReadAllRecords+ defaultIStorage.ReadAllRecords._deadSlots).Tests
ReopenRoundTripMatrixTests(4 storage variants x insert/update/delete x 3 reopens) + empty-value reopen regressions + legacy delete-after-update regression.[2.0.0.2] Fixedupdated.