Prerequisite for rearchitecture - #176
Open
pfongkye wants to merge 3 commits into
Open
Conversation
Review rows were deleted by mergeRequestIid alone, so two projects sharing an iid would cross-delete each other's reviews on close/merge. The read counterpart getReviewsByMergeRequestIid is already project-scoped and the caller already has projectId in scope; only the delete leaked. This is also a correctness prerequisite before GitHub PR numbers coexist with GitLab iids. Also make the sequelize test mock's destroy remove all matching rows (faithful to real Sequelize) so the regression test is meaningful. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Snapshot the exact chat.postMessage / chat.update payload for open, closed, merged, approved-in-progress and fully-approved states, driving buildReviewMessage directly and asserting its return value (nothing is sent). This is the byte-for-byte regression gate for the upcoming "pure renderer" refactor, which must keep these payloads identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pin the current gitlabUsername -> "<username>@<domain>" per EMAIL_DOMAINS -> users.lookupByEmail behavior: it queries one email per configured domain in order, returns the first match and short-circuits, and resolves to undefined when none match (preserving the graceful 204 path). Domains are derived from CONFIG so the test tracks EMAIL_DOMAINS. Guards the upcoming SlackUserResolver strategy-chain refactor. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 105 105
Lines 2295 2295
Branches 444 444
=======================================
Hits 2051 2051
Misses 231 231
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare Rearchitecturing