fix(track): follow the caret when typing right after a click (#328) - #336
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Clicking into Notepad and typing at once lost the first ~8 characters: they fell inside the 1 s quiet period after a mouse button, so the view stayed on the pointer while the caret was off screen. The click's own caret move is still consumed; any key pressed after the click now counts as typing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #328. Version 0.21.3.
The caret was not followed while typing right after a click (Notepad: about 40 characters typed before the view moved). The 1 s click quiet period, meant to keep a click from yanking the view, also swallowed the typing that follows a click.
src/view_target.h: newkeyAfterButtoninput. A key pressed after the last mouse button means typing, so the click quiet period ends early:(msSinceButton >= kClickQuietMs || keyAfterButton) && msSinceKey <= kKeyDrivenMs.src/main.cpp: setskeyAfterButtonfrom the last key-down and last button stamps.tests/test_view_target.cpp: two tests (typing after a click follows at once; a click with no key still waits).trackLog=1diagnostics (hidden key, default 0): logs every caret/focus event with the gate inputs and every tracking enable change. Kept for the still unreproduced Discord jump-to-end report; no cost when off.Gates:
build.bat testpass,build.batbuilds Wind.exe. Field: deployed to this machine since 2026-10-03 for hands-on testing; merged on Max's go-ahead. Unsigned (no SignPath enrollment yet).🤖 Generated with Claude Code
https://claude.ai/code/session_01KPUNAWcwghXdHCApcKKjSG