Add deps/ unconditionally#307
Merged
Merged
Conversation
Coverage Report for CI Build 28668762831Coverage increased (+0.05%) to 83.413%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This was referenced Jul 3, 2026
MarcelGeo
requested changes
Jul 3, 2026
|
|
||
| try: | ||
| import dateutil.parser | ||
| from dateutil.tz import tzlocal |
Contributor
There was a problem hiding this comment.
It's not eough to add here also trustore?
Contributor
Author
There was a problem hiding this comment.
truststore is not used here..
we don't need it to import it e.g. for CLI
MarcelGeo
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Put dependencies in deps/ dir on sys.path unconditionally. The host (QGIS) may already provide some (like
dateutil), which previously skipped this bundling step.