Update post processing scripts and docs - #256
Conversation
Ed Hone (EdHone)
left a comment
There was a problem hiding this comment.
In principle I'm happy with all the changes and their efficacy is demonstrated by the successful CI run. My only concern is that this would make the release version of the library only work with vernier data created from this release or later. That is a valid approach, but I just wanted to confirm that's the plan.
Also, the file format version is 1.0, will this version number only change when the file format is changed, or will it match the version of the software?
For the format version it is intended to only change if the format changes, it may remain at 1.0 for all eternity, it should only change if there is a change to the output format of vernier that breaks the post processing, that way there is a way to link the post-processing tooling to files which work, it would be unsustainable to try and maintain backward compatibility for all time. In terms of the ability to use the post-processing scripts with older versions of the output, that's a tricky one, if we don't do so now we will never stop supporting the older format I think. At the moment people with older outputs can probably just add the header to the top of their files and it will likely work though it will not be guaranteed to be correct, if it doesn't however they may get a horrible error. |
Ed Hone (EdHone)
left a comment
There was a problem hiding this comment.
Happy with that response - this has passed my code review
Description
PR #254 added a proper header to the output files including a format version, this PR bring the post-processing in line with that as well as updating the documentation to describe the new tooling a bit more clearly.
Linked issues
Closes # (issue)
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: