590 apps specific - #591
Conversation
|
Yaswant Pradhan (@yaswant) , Matthew Hambley (@MatthewHambley) , Sam Clarke-Green (@t00sa) - I have no idea why the CLA check failed, as far as I can see I have signed the CONTRIBUTORS file: With Otherwise ready for review. |
Joerg Henrichs (@hiker) I cant see an entry for you in the https://github.com/MetOffice/fab/blob/main/CONTRIBUTORS.md?plain=1 or in your PR branch. If you update that file in your branch the check should pass. If you have signed the CLA in a different PR, maybe that is not merge in main yet so the cla-checker cant see it? Once that PR is merged, the error should disappear. |
|
Yes indeed, I looked at the wrong branch - sorry. I might just add it to all my PRs, to give you flexibility in which order to review them :) Thanks! |
This allows lfric_atm to use lfric-atm-specific compilation option.