Skip to content

590 apps specific - #591

Open
Joerg Henrichs (hiker) wants to merge 6 commits into
mainfrom
590_apps_specific
Open

590 apps specific#591
Joerg Henrichs (hiker) wants to merge 6 commits into
mainfrom
590_apps_specific

Conversation

@hiker

Copy link
Copy Markdown
Collaborator

This allows lfric_atm to use lfric-atm-specific compilation option.

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Aug 12, 2026
@hiker Joerg Henrichs (hiker) added the Ready for review Indicating that a PR is ready to be reviewed. label Aug 12, 2026
@hiker
Joerg Henrichs (hiker) requested review from a team and mo-lucy-gordon and removed request for a team August 12, 2026 10:52
@hiker

Copy link
Copy Markdown
Collaborator Author

Yaswant Pradhan (@yaswant) , Matthew Hambley (@MatthewHambley) , Sam Clarke-Green (@t00sa) - I have no idea why the CLA check failed, as far as I can see I have signed the CONTRIBUTORS file:

| GitHub Username | Real Name       | Affiliation                      |
|-----------------|-----------------|----------------------------------|
...
| hiker           | Joerg Henrichs  | Bureau of Meteorology, Australia |

With git config showing: user.name=Joerg Henrichs

Otherwise ready for review.

@yaswant

Yaswant Pradhan (yaswant) commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Yaswant Pradhan (Yaswant Pradhan (@yaswant)) , Matthew Hambley (Matthew Hambley (@MatthewHambley)) , Sam Clarke-Green (Sam Clarke-Green (@t00sa)) - I have no idea why the CLA check failed, as far as I can see I have signed the CONTRIBUTORS file:

| GitHub Username | Real Name       | Affiliation                      |
|-----------------|-----------------|----------------------------------|
...
| hiker           | Joerg Henrichs  | Bureau of Meteorology, Australia |

With git config showing: user.name=Joerg Henrichs

Otherwise ready for review.

Joerg Henrichs (@hiker) I cant see an entry for you in the https://github.com/MetOffice/fab/blob/main/CONTRIBUTORS.md?plain=1 or in your PR branch. If you update that file in your branch the check should pass.

If you have signed the CLA in a different PR, maybe that is not merge in main yet so the cla-checker cant see it? Once that PR is merged, the error should disappear.

@hiker

Copy link
Copy Markdown
Collaborator Author

Yes indeed, I looked at the wrong branch - sorry. I might just add it to all my PRs, to give you flexibility in which order to review them :) Thanks!

@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA Ready for review Indicating that a PR is ready to be reviewed.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants