102 add fab script - #137
Draft
Joerg Henrichs (hiker) wants to merge 9 commits into
Draft
Conversation
…fab script itself.
Joerg Henrichs (hiker)
requested a review
from Giorgia (GiorgiaLine)
as a code owner
August 18, 2026 07:40
Joerg Henrichs (hiker)
marked this pull request as draft
August 18, 2026 13:08
39 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Adds a Fab build script for Jules. It supports gfortran, ifort, ifx, and Cray's ftn. I don't have access to any other platforms, additional compiler can be supported easily.
Some small changes to the flags have been made (e.g. one 'ignore compiler error' change is apparently not required with newer versions of the compiler anymore). The biggest change (as far as I can see) was that I have removed array-bounds checking from all(!!) gfortran compilation, it is now only used in the debug build.
Sci/Tech Reviewer:
Code Reviewer:
This needs a currently unreleased version of Fab, namely the branch
fab_for_jules. Reason is a current bug in Fab that ignores preprocessor flags set in the preprocessing tool. I'll update this once the corresponding PR has been merged.Additionally, it also needs a new version of fparser, waiting for a bugfix to be merged in (reason is that the file
init_output_mod.F90supports intel-compiler-specific arguments to inquire, which fparser flagges as error). A PR has been submitted, and we will do a release of fparser soon for that.MetOffice/fab#598
MetOffice/fab#597
stfc/fparser#523
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
rose-meta/jules-sharedthen have you supplied a linked UM and LFRic Apps PR?Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
WIP
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section owners.
Technical
Scientific
N/A
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review