Skip to content

102 add fab script - #137

Draft
Joerg Henrichs (hiker) wants to merge 9 commits into
MetOffice:mainfrom
hiker:102_add_fab_script
Draft

102 add fab script#137
Joerg Henrichs (hiker) wants to merge 9 commits into
MetOffice:mainfrom
hiker:102_add_fab_script

Conversation

@hiker

@hiker Joerg Henrichs (hiker) commented Aug 18, 2026

Copy link
Copy Markdown

PR Summary

Adds a Fab build script for Jules. It supports gfortran, ifort, ifx, and Cray's ftn. I don't have access to any other platforms, additional compiler can be supported easily.

Some small changes to the flags have been made (e.g. one 'ignore compiler error' change is apparently not required with newer versions of the compiler anymore). The biggest change (as far as I can see) was that I have removed array-bounds checking from all(!!) gfortran compilation, it is now only used in the debug build.

Sci/Tech Reviewer:
Code Reviewer:

This needs a currently unreleased version of Fab, namely the branch fab_for_jules. Reason is a current bug in Fab that ignores preprocessor flags set in the preprocessing tool. I'll update this once the corresponding PR has been merged.

Additionally, it also needs a new version of fparser, waiting for a bugfix to be merged in (reason is that the file init_output_mod.F90 supports intel-compiler-specific arguments to inquire, which fparser flagges as error). A PR has been submitted, and we will do a release of fparser soon for that.

MetOffice/fab#598
MetOffice/fab#597
stfc/fparser#523

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • [N/A] If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • [N/A] If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
  • [N/A] If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
  • [N/A] I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

trac.log

Security Considerations

  • [N/A] I have reviewed my changes for potential security issues
  • [N/A] Sensitive data is properly handled (if applicable)
  • [N/A] Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • [N/A] Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly
    WIP

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

N/A

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogeochemistry
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Aug 18, 2026
@hiker
Joerg Henrichs (hiker) marked this pull request as draft August 18, 2026 13:08
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants