Fix create no window - #143
Open
YlanzinhoY wants to merge 2 commits into
Open
Conversation
Skip SteamProcess.kill outside Windows so taskkill and subprocess.CREATE_NO_WINDOW are never evaluated on Linux.
Use the SLSsteam-aware Linux helper before config writes while preserving the existing taskkill flow on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Linux download issue reported in #141, where game folders were not created after downloading.
Root cause
The download flow attempted to use the Windows-only
taskkillcommand andsubprocess.CREATE_NO_WINDOWflag on Linux, producing the following error:Testing
CREATE_NO_WINDOWerror before applying the fix.