Skip to content

fix(ui): eliminate UI flickering, modal race conditions, and animation jank #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tell-Shanks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): eliminate UI flickering, modal race conditions, and animation jank #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sff/webui/css/cards.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,9 @@
/* ── Card stagger animation ─────────────────────────── */

.game-card.stagger-in {
animation: cardStaggerIn 0.3s ease forwards;
animation: cardStaggerIn 0.25s ease forwards;
opacity: 0;
will-change: opacity, transform;
}

@keyframes cardStaggerIn {
Expand Down
9 changes: 8 additions & 1 deletion sff/webui/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,18 @@ a:hover { text-decoration: underline; }

.page {
display: none;
opacity: 0;
}

.page.active {
display: block;
animation: fadeIn 0.2s ease;
opacity: 1;
animation: fadeIn 0.18s ease forwards;
/* Prevent layout thrash — start from rendered state */
will-change: opacity;
/* CSS containment: this page's layout/style changes don't
affect siblings, eliminating cross-page repaint flicker */
contain: layout style;
}

.page-header {
Expand Down
22 changes: 13 additions & 9 deletions sff/webui/css/premium.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ body::before {
radial-gradient(ellipse 40% 30% at 15% 85%, rgba(80, 200, 150, 0.025) 0%, transparent 40%);
pointer-events: none;
z-index: 0;
/* Promote to GPU compositing layer — prevents this static gradient
from triggering main-thread repaints on scroll / page transitions */
will-change: transform;
transform: translateZ(0);
}

.content {
Expand Down Expand Up @@ -90,7 +94,7 @@ h3 { font-size: 15px; font-weight: 600; }
padding: 16px 18px;
border-radius: 14px;
border: 1px solid transparent;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
background: rgba(255, 255, 255, 0.02);
position: relative;
}
Expand Down Expand Up @@ -125,7 +129,7 @@ h3 { font-size: 15px; font-weight: 600; }
justify-content: center;
background: transparent;
border-radius: 0;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
position: relative;
z-index: 1;
}
Expand Down Expand Up @@ -190,7 +194,7 @@ h3 { font-size: 15px; font-weight: 600; }
background: rgba(255, 255, 255, 0.02);
position: relative;
overflow: hidden;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
text-align: center;
}

Expand Down Expand Up @@ -223,7 +227,7 @@ h3 { font-size: 15px; font-weight: 600; }
justify-content: center;
background: transparent;
border-radius: 0;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
position: relative;
z-index: 1;
}
Expand Down Expand Up @@ -372,7 +376,7 @@ h3 { font-size: 15px; font-weight: 600; }
border: 1px solid transparent;
background: rgba(255, 255, 255, 0.02);
position: relative;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
}

.game-list-item::before {
Expand Down Expand Up @@ -426,7 +430,7 @@ h3 { font-size: 15px; font-weight: 600; }
border-radius: 10px;
font-weight: 600;
padding: 10px 20px;
transition: all 0.2s ease;
transition: background 0.2s ease, color 0.2s ease, border-color 0.2s ease, transform 0.2s ease, box-shadow 0.2s ease;
font-family: 'Manrope', sans-serif;
font-size: 13px;
}
Expand Down Expand Up @@ -580,7 +584,7 @@ input:focus, select:focus {
border-radius: 10px;
font-size: 12px;
font-weight: 600;
transition: all 0.2s ease;
transition: background 0.2s ease, color 0.2s ease, border-color 0.2s ease, transform 0.2s ease, box-shadow 0.2s ease;
}

.theme-swatch:hover {
Expand Down Expand Up @@ -1192,7 +1196,7 @@ select:focus-visible,
border: 1px solid transparent;
background: rgba(255, 255, 255, 0.02);
position: relative;
transition: all 0.25s ease;
transition: background 0.25s ease, color 0.25s ease, border-color 0.25s ease, transform 0.25s ease, box-shadow 0.25s ease;
}

.download-item::before {
Expand Down Expand Up @@ -1253,7 +1257,7 @@ select:focus-visible,
border-radius: 12px;
border: 1px solid transparent;
background: rgba(255, 255, 255, 0.02);
transition: all 0.2s ease;
transition: background 0.2s ease, color 0.2s ease, border-color 0.2s ease, transform 0.2s ease, box-shadow 0.2s ease;
}

.library-option:hover {
Expand Down
19 changes: 15 additions & 4 deletions sff/webui/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,19 +2095,30 @@ window.App = (function() {
try { games = JSON.parse(json || '[]'); } catch(e) { games = []; }
var select = document.getElementById('home-game-select');
if (!select) return;
// Keep the placeholder option
select.innerHTML = '<option value="">-- Select a game --</option>';
// Preserve the currently selected value so the visible display
// doesn't flash to blank while the list rebuilds.
var prevValue = select.value;
// Build into a fragment — one DOM flush prevents layout thrash
var frag = document.createDocumentFragment();
var placeholder = document.createElement('option');
placeholder.value = '';
placeholder.textContent = '-- Select a game --';
frag.appendChild(placeholder);
games.forEach(function(game) {
var opt = document.createElement('option');
opt.value = game.app_id;
opt.textContent = game.name + ' (' + game.app_id + ')';
select.appendChild(opt);
frag.appendChild(opt);
});
select.innerHTML = '';
select.appendChild(frag);
// Restore previous selection if it still exists
if (prevValue) select.value = prevValue;
// Re-apply active search filter after dropdown rebuilds
var searchInp = document.getElementById('home-game-search');
if (searchInp && searchInp.value.trim()) {
var filterVal = searchInp.value.trim().toLowerCase();
setTimeout(function() { _filterGameDropdown(filterVal); }, 60);
setTimeout(function() { _filterGameDropdown(filterVal); }, 0);
}
});
}
Expand Down
20 changes: 17 additions & 3 deletions sff/webui/js/components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,11 @@ window.Components = (function() {
wrap.appendChild(img);
}

// Stagger animation delay
// Stagger animation delay — capped at 0.4s so large grids don't
// have late cards blinking in after the user thinks rendering is done.
if (typeof options.index === 'number') {
card.style.animationDelay = (options.index * 0.05) + 's';
var delay = Math.min(options.index * 0.04, 0.4);
card.style.animationDelay = delay + 's';
}

return card;
Expand Down Expand Up @@ -250,17 +252,26 @@ window.Components = (function() {
}

// Show/hide a modal
// Uses a generation counter per modal to cancel stale hide timeouts —
// previously a hideModal timer would fire after a showModal call and
// re-hide the freshly opened modal (visible as a blink).
function showModal(modalId) {
var modal = document.getElementById(modalId);
if (!modal) return;
// Bump generation so any pending hideModal setTimeout becomes a no-op
modal.dataset.modalGen = ((parseInt(modal.dataset.modalGen, 10) || 0) + 1).toString();
modal.classList.remove('hidden', 'modal-hiding');
}

function hideModal(modalId) {
var modal = document.getElementById(modalId);
if (!modal || modal.classList.contains('hidden')) return;
var gen = ((parseInt(modal.dataset.modalGen, 10) || 0) + 1).toString();
modal.dataset.modalGen = gen;
modal.classList.add('modal-hiding');
setTimeout(function() {
// Only apply if no showModal() or newer hideModal() has run since
if (modal.dataset.modalGen !== gen) return;
modal.classList.remove('modal-hiding');
modal.classList.add('hidden');
}, 150);
Expand Down Expand Up @@ -451,7 +462,10 @@ window.Components = (function() {

new MutationObserver(function() {
clearTimeout(syncTimer);
syncTimer = setTimeout(function() { self._syncOptions(); }, 10);
// 50ms debounce: batches rapid option inserts (e.g. filling a
// 300-game dropdown one option at a time) into a single sync,
// eliminating the visible flicker of intermediate states.
syncTimer = setTimeout(function() { self._syncOptions(); }, 50);
}).observe(this._select, { childList: true });

this._ui.querySelector('.custom-select-display').addEventListener('click', function(e) {
Expand Down