Drop support for PHP 7.x, and PHP 8.0/8.1, new minimum is 8.2. Update PHPUnit to 11. - #166
Conversation
This supports the latest upstream fork/destination change, which is now in the 4.x line for active support
There was a problem hiding this comment.
Old artifact, unused so cleaned up.
As we have updated our baseline PHP version support, we can update PHPUnit too. Currently PHPUnit v11 is the latest version that supports PHP ^8.2. When we drop 8.2 support we can update to newer PHPUnit releases again.
|
Hi @robbieaverill Thank you for the PR! This looks good to me. Will just get another set of eyes on it quickly |
|
Thx @robbieaverill, this is great. A couple of additional thoughts:
Not sure if you want to do this in a separate release branch/PR after this PR, but just noticed that you increased it in the README file to 2.4.0
I'm not deeply enough in the PHP world to properly comment on how urgent this would be to fix/change, just wanted to bring it to your attention at least. |
|
Hey @TheRealAgentK, thanks for the reply. You're right that the 1.x to 2.x release bump was for changing PHP support versions, and I considered that, however I thought it best to keep it as a minor release for a few reasons:
That said, totally fine with going to a 3.x bump if you'd rather keep it clean! Re: the PHPCS run, good call - I'll add it to the GH Actions run as part of this PR. The PHP 8.5 incompatibility I think we should track separately, I'll validate and open a new issue for it. |
Ok, cool - I'm totally happy to go with your recommendation for the version bump to 2.4.0 then. I think that's a reasonable approach with your additional context. And all good re the other items, too. I think we can approve the PR after the GH actions addition and split out the potential PHP 8.5 code fix into another PR. |
TheRealAgentK
left a comment
There was a problem hiding this comment.
LGTM now, thx @robbieaverill
This will be released as a new minor release. We won't be adding new features to the existing PHP 7.x/8.0/8.1 release line, so this new release will take the next minor release line. Users should upgrade to a supported PHP version to continue receiving features from this project.