feat(dlss): add Ultra Performance mode support - #6
Open
Gabrieli2806 wants to merge 1 commit into
Open
Conversation
kbatten
added a commit
to kbatten/MCVR
that referenced
this pull request
Aug 7, 2026
…dges as pairs, not 4->6 The targeted-block outline rendered as an open "L" with edges shooting past the block. 26.2 emits the outline as GL_LINES -- two vertices per edge, via ShapeOutlineFeatureRenderer -> VoxelShape.forAllEdges, each vertex carrying the edge direction as its normal. The native LINES expansion (unchanged from the 1.21 path, whose outline used a different vertex layout) first reshuffled every group of four vertices into six, which under 26.2's pair layout fabricated a spurious diagonal edge (v2->v1) for every two real edges -- the extra edges. Drop the reshuffle: pair consecutive vertices (start, end) directly and expand each edge into its thin box (tube) as before. Native-only; on the main.26_2 branch so the 1.21 path is untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013BGtXkPKqW9Zkig9qhN1xK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the DLSS mode handling logic in the
DLSSModuleto support the "ultra performance" mode. The main change is to recognize and set the appropriate internal value when the "ultra performance" mode is specified.DLSS mode handling improvements:
src/core/render/modules/world/dlss/dlss_module.cpp: Added support for therender_pipeline.module.dlss.attribute.mode.ultra_performancemode, mapping it toNVSDK_NGX_PerfQuality_Value_UltraPerformancein thesetAttributesmethod.