Own editor AST caches and share Swing dispatch - #35
Merged
Pelotrio merged 4 commits intoSep 11, 2026
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Pelotrio
added this pull request to stack #30
September 11, 2026 15:54
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
from
September 11, 2026 16:25
33dc466 to
2d6bcde
Compare
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
2 times, most recently
from
September 11, 2026 16:59
73ba99d to
ffb71e7
Compare
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
from
September 11, 2026 17:23
ffb71e7 to
49d4afc
Compare
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
from
September 11, 2026 17:27
49d4afc to
a2b64d6
Compare
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
from
September 11, 2026 17:46
a2b64d6 to
e505286
Compare
Pelotrio
force-pushed
the
codex/companion-editor-cache
branch
from
September 11, 2026 18:06
e505286 to
55f437c
Compare
An inline-value mouse event queued before a project switch could reach the window after closeProjectWindows() cleared the debugger window, dereferencing a null or replaced project scope and recreating a window nobody disposes. The callback now captures its originating scope and re-checks on the EDT that the window is live and the scope is still current and active before showing the value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M7DQH1k854dr2KVQXZmRqY Took 2 minutes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AST models and change listeners now belong to EditorTabs instead of process-wide maps. Each Java editor passes that cache to parsing, highlighting, symbol navigation, code insight, status breadcrumbs and breakpoint completion. Closing project editors clears their cache; disposal also removes semantic highlighting subscriptions and rejects later document updates.
Equivalent nonblocking Swing dispatch uses UIUtils.onEdt. Synchronous application lifecycle handoffs and navigation callbacks retain their existing ownership guards and timing.
Validation: full Companion suite passed, including new tests for identical keys in independent caches and pending publication after clear. Root
:check :localBundle --warning-mode failpassed with offline local Maven dependencies; source editor/runtime tree/resource-tab harness rendering inspected.Stacked on #34. This completes the remaining editor-cache and EDT cleanup in revision 2 of the architecture plan.