Use Serilog for logging - #3323
Open
ColinM9991 wants to merge 2 commits into
Open
Conversation
|
Build for this pull request: |
|
Build for this pull request: |
ColinM9991
changed the title
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
ColinM9991
marked this pull request as ready for review
August 31, 2026 15:17
ColinM9991
changed the title
ColinM9991
force-pushed
the
serilog-logging
branch
from
August 31, 2026 17:15
50f25fd to
3e866f4
Compare
|
Build for this pull request: |
DocMoebiuz
requested changes
Sep 1, 2026
DocMoebiuz
left a comment
DocMoebiuz
left a comment
Collaborator
There was a problem hiding this comment.
Add dependency to our list in the about dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using Serilog for logging. It was originally thought that logging was saturating the thread pool as that too used Task.Run. Offloading to Serilog allows Serilog to handle log events in a more optimised fashion.
Related issues
Addresses some threadpool bound work as part of #3324
Out-of-scope
A full rewrite of logging has not be implemented in this change in order to keep the scope short.