SCRUM-326: fix(rewards) adopt Result pattern, fix enum status filter, add code search, and add unit tests for inventory query

[Moha-sami]

Summary

Follow-up fix for Jemy's PR #371 (SCRUM-326-REWARD-EP-7).

Changes

• Result Pattern & 404 Handling:
  • Replaced throw new ValidationException with Result<PaginatedVouchersResponseDto>.NotFound.
  • Updated RewardsController.GetInventory to map Result states and corrected ProducesResponseType to PaginatedVouchersResponseDto.
  • Used Query(true) (AsNoTracking) for read check.
• Filter & Search Bug Fixes:
  • Fixed enum status filtering (v.Status == parsedStatus instead of broken string comparison).
  • Fixed typo in VoucherInventoryFilterQueryDto (string? VoucherCode instead of VoucherStatus?).
  • Implemented VoucherCode substring search filter.
  • Added inverted date range normalization.
• Pagination & Ordering:
  • Added explicit .OrderByDescending(v => v.CreatedAt) prior to Skip/Take.
  • Sanitized pageSize usage (Take(pageSize)).
• Unit Tests:
  • Added 8 unit tests in GetRewardVoucherInventoryQueryTests.cs.
  • Verified 734/734 tests pass locally.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
hr-system	Ready	Preview	Sep 19, 2026 10:26pm UTC

[github-actions]

Automated PR Validation Feedback

All Checks Passed!

• Jira key / Task reference detected.
• Code formatting passed (4 changed C# file(s)).
• .NET 10 solution compiled successfully.
• .NET analyzers passed.
• Security scan skipped (no dependency changes in this PR).

Ready for maintainer review!