feat: Runtime options support for Y axis scaling for live diagnostics graphs - #403
Merged
Merged
Conversation
AlexDenfordSkyboxLabs
requested review from
BrandonChanSkybox,
SBLMikeDemone and
frgarc
August 7, 2026 16:23
BrandonChanSkybox
approved these changes
Aug 7, 2026
SBLMikeDemone
approved these changes
Aug 7, 2026
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
Contributor
There was a problem hiding this comment.
A few small things, but Francisco is the true web dev here
| let sectionStart = 0; | ||
| const sectionLabels = latestData.map(stat => { | ||
| const sectionHeight = Math.max(0, stat.value); | ||
| const label = catageoryLabels?.[stat.category ?? ''] ?? stat.category ?? ''; |
Contributor
There was a problem hiding this comment.
Should it be an error if any of these are undefined?
frgarc
approved these changes
Aug 10, 2026
frgarc
left a comment
frgarc
left a comment
Contributor
There was a problem hiding this comment.
Other than having properties into CSS files, it LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changed the chunks diagnostics display within the World tab to use sqrt instead of linear to better show the ticking chunks (very small amount ~25) vs the loaded chunks (very large amount ~30,000).
Also added option for showSectionLabels (see image below)
Before:
New scaling + new option dropdown:
