fix: register -n and --n-molecules as separate option strings - #207
Open
galjos wants to merge 1 commit into
Open
fix: register -n and --n-molecules as separate option strings#207galjos wants to merge 1 commit into
galjos wants to merge 1 commit into
Conversation
The -n and --n-molecules aliases were passed to add_argument as a single comma-joined string, so argparse registered one malformed option. The help text advertised --n-molecules, but using it failed with unrecognized arguments and only -n worked via prefix matching. Splitting the aliases into separate option strings makes both work.
Contributor
|
PYLINT REPORT Your code has been rated at 9.78/10 Full reportRaw metrics
Duplication
Messages by category
% errors / warnings by module
Messages
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #207 +/- ##
=======================================
Coverage 93.94% 93.94%
=======================================
Files 177 177
Lines 9227 9227
=======================================
Hits 8668 8668
Misses 559 559
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option was added as one string
"-n, --n-molecules"instead of two, so the advertised long flag was rejected as unrecognized. Split into two option strings.The added tests pin the option strings, both flags, and the default.
Fixes #206.