feat(tui): lazy-create the session on first use with the v2 engine by liruifengv · Pull Request #2458 · MoonshotAI/kimi-code

liruifengv · 2026-07-31T07:59:41Z

Related Issue

No linked issue — this is part of the ongoing agent-core-v2 engine rollout for the interactive TUI.

Problem

The TUI eagerly creates a session at startup (KimiTUI.init calls harness.createSession even when the user has not sent anything yet). Under the v2 engine this is unnecessary: a workspace handler can exist without a session, the main agent is only materialized on first use, and skills live on the workspace rather than the session. Eager creation also means the session appears in the picker / persisted session store before the user has done anything.

What changed

With the v2 engine (KIMI_CODE_EXPERIMENTAL_FLAG), the TUI now starts session-less and creates the session on first use:

Startup: non-resume startups no longer create a session; --session / --continue resume and the --session "" picker behave as before. The footer shows the config defaults the engine would apply at createSession time (model, defaultPermissionMode, defaultPlanMode, thinking effort, context cap) so nothing goes blank while waiting.
First use triggers creation: sending a message, a bash-mode command, or a session-requiring slash command (/plan /yolo /auto /compact /goal /permission /settings /undo /web /fork /export-* /init /btw /swarm /add-dir /plugins /mcp /usage /status /title) and skill/plugin commands all lazy-create the session via a shared ensureSession() path. /login, /model, /logout, /provider, /reload, /copy, /theme and other session-independent commands never trigger creation; activateModelAfterLogin no longer creates a session after login/model switch.
Skills without a session: refreshSkillCommands falls back to harness.listWorkspaceSkills(workDir) when no session exists (plugin skills are missing from that list until the session is created and refreshed). Plugin commands are already app-global under v2, so a new KimiHarness.listPluginCommands() exposes them session-less (the base RPC returns an empty list for v1).
--agent / --agent-file: the startup agent binding is carried in appState and applied to the first lazy-created session, instead of being lost when session creation moves out of init().
/plugins: fixed a latent unhandled-rejection when the command runs without an active session (its internal requireSession throw was dispatched via void).
The v1 engine path is unchanged: all lazy-creation branches are guarded by the v2 flag, so v1 keeps its historical eager-creation behavior.

Checklist

I have read the CONTRIBUTING document.
I have linked a related issue, or explained the problem above.
I have added tests that prove my feature works.
Ran gen-changesets skill, or this PR needs no changeset.
Ran gen-docs skill, or this PR needs no doc update.

Start the interactive TUI session-less under the v2 engine and create the session on first use (message, bash input, or a session-requiring slash command) instead of at startup. Skills and plugin commands are resolved from the workspace/app-global catalogs without a session, and the footer shows config defaults (model, permission, plan mode, thinking effort, context cap) until the session exists.

changeset-bot · 2026-07-31T07:59:45Z

⚠️ No Changeset found

Latest commit: 0c750fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2026-07-31T08:02:20Z

pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@0c750fb

npx https://pkg.pr.new/@moonshot-ai/kimi-code@0c750fb

commit: 0c750fb

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3755653bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…king Concurrent first-use triggers (double Enter, a slash command right after a prompt) both observed `session === undefined` and created their own session, letting the later setSession close the first one mid-dispatch. Share an in-flight creation promise instead. A session-only thinking choice (model picker Alt+S) made before the first session exists only updated appState, so the lazy-created session fell back to the engine default while the footer showed the chosen effort. Carry it as a first-session thinking override and clear it on creation.

liruifengv · 2026-07-31T08:24:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79fe2a18cb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

The v2 engine applies config.defaultPlanMode at session create time (sessionLifecycleService), so passing the pre-filled appState.planMode as the create override entered plan mode twice and threw 'Already in plan mode' on the first message. Pass only the explicit CLI --plan intent for session-less v2 creation; the config default stays footer-only.

liruifengv · 2026-07-31T08:47:56Z

@codex review

…ation

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd52d72a04

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ings session-less A bash command submitted while the first prompt is still being lazy-created shared the in-flight creation promise but resumed past handleUserInput's busy check, running runShellCommand concurrently with the prompt. Re-check streamingPhase after the await and queue instead. /settings is a local settings entry point: opening it must not require or create a session, so it no longer triggers lazy creation; its session-requiring sub-items keep their own errors.

liruifengv · 2026-07-31T09:03:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e21d4cfa3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ins session-free A skill/plugin or idle-only slash command submitted while the first prompt was still being lazy-created shared the in-flight creation promise but resumed past the availability check resolved before the await, running concurrently with the prompt's turn. Re-check the busy gate after the shared await in the skill, plugin-command and builtin dispatch paths. /plugins is app-global on the v2 engine, so a session-less startup no longer creates a session (or fails with LLM-not-set) just to manage plugins: the harness now exposes the global plugin API and the command routes through it until a session exists.

liruifengv · 2026-07-31T09:26:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5e87a1ccd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

The bare and `list` forms already tolerate a missing session, but the blanket lazy-create gate forced a session (or failed with LLM-not-set) before they could run. Only the path-adding form needs a live session, so it now lazy-creates inside the handler instead of in the dispatch preflight.

liruifengv · 2026-07-31T09:43:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7392b65bf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…nds after reload /add-dir list looked only at session.summary, so pending startup additionalDirs were reported as absent until a session existed; fall back to appState when session-less. /plugins reload updated the app-global service but left the TUI's plugin slash-command map stale, so new or re-enabled commands kept parsing as prompts; rebuild it from the reloaded service (which also covers the app-global path before the first session exists).

liruifengv · 2026-08-01T08:34:16Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bccb66a734

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…-entry /reload refreshed only the model/provider dictionaries while session-less, so defaults edited externally (or a newly added default model) left appState.model empty/stale and the first lazy-created session failed with LLM-not-set or used the old value. Reuse the startup default-hydration path for the no-session reload case. /plan on as the first command with defaultPlanMode=true re-entered plan mode after the engine had already applied the config default at create, throwing Already in plan mode. Skip the call when the session is already in the requested mode.

liruifengv · 2026-08-01T08:57:01Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2cffe2ed7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hydrateLazyConfigDefaults only patched model when the reloaded config still had a default, so removing defaultModel from config.toml left appState.model stale and the first lazy-created session passed it explicitly instead of failing or following the engine's current defaults. Reset model and context cap when the default is gone.

liruifengv · 2026-08-01T09:09:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fa8827b55

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…--plan A removed defaultPermissionMode left appState carrying the old elevated mode, which createSessionFromCurrentState then passed explicitly to the first lazy-created session; reset to manual when no CLI permission flag is present. With both defaultPlanMode and --plan set, the create payload passed planMode: true even though the engine already entered plan mode from the config default, throwing Already in plan mode on the first prompt. Track the config default separately and suppress the --plan override when it is already active.

liruifengv · 2026-08-01T09:30:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f1d31a3e4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Read-only views (/status, /usage, /mcp, bare /title) already degrade gracefully without a session, so forcing lazy creation made them fail with LLM-not-set or create an unused persisted session; they no longer trigger creation, and /title <name> lazy-creates only for the mutation. /permission, /auto and /yolo are pending-mode choices: with no session on v2 they now record the mode in appState (which the lazy create path passes to the engine) instead of failing or creating a session just to pick a mode. The runtime permission is applied once a session exists.

liruifengv · 2026-08-01T09:54:08Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f43d440356

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

setSession assigned host.session mid-assembly, so a follow-up prompt or command in that window skipped the shared creation promise and dispatched against a session whose subscription and runtime sync had not finished. Check the in-flight promise before the assigned-session fast path. /mcp required a live session even though the v2 connection set is workspace-scoped, so it errored until an unrelated prompt created one. Route it through a workspace-level MCP view (harness passthrough over the handler's shared connection manager) before the first session exists.

liruifengv · 2026-08-01T10:49:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c750fb755

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-01T10:54:57Z

+    const handler = await this.engineAccessor
+      .get(IWorkspaceLifecycleService)
+      .handlerFor({ root: normalizeRequiredWorkDir('listWorkspaceMcpServers', workDir) });
+    return handler.accessor.get(IWorkspaceMcpService).connectionManager().list() as readonly McpServerInfo[];


Wait for workspace MCP initialization

When /mcp is the first v2 action for a workspace, handlerFor() has only materialized the Workspace scope; WorkspaceMcpService.initialize() still loads MCP config and connects servers behind its ready promise, while session create/resume paths await that before exposing the session MCP list. Fresh evidence is this new workspace-level route reading connectionManager().list() immediately, which can show an empty or pending/tool-less MCP list until a later session creation or retry makes the same configured servers appear; await the workspace MCP readiness before returning the list.

Useful? React with 👍 / 👎.

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts Outdated

Merge remote-tracking branch 'origin/main' into feat/lazy-session-cre…

e30180d

…ation

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts Outdated

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/commands/add-dir.ts Outdated

Comment thread apps/kimi-code/src/tui/commands/plugins.ts

test(tui): add pluginCommandMap to the MessageDriver interface

5562fd7

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts Outdated

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

liruifengv added 2 commits August 1, 2026 17:04

test(tui): widen the getConfig mock return type for the reload case

0bce21a

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts Outdated

Comment thread apps/kimi-code/src/tui/kimi-tui.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts Outdated

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread apps/kimi-code/src/tui/kimi-tui.ts

Comment thread apps/kimi-code/src/tui/commands/dispatch.ts

chatgpt-codex-connector Bot reviewed Aug 1, 2026

View reviewed changes

Uh oh!

Conversation

liruifengv commented Jul 31, 2026

Related Issue

Problem

What changed

Checklist

Uh oh!

changeset-bot Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

pkg-pr-new Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liruifengv commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liruifengv commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Aug 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

liruifengv commented Aug 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

liruifengv commented Aug 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

changeset-bot Bot commented Jul 31, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 31, 2026 •

edited

Loading