Add CI: run the harness test suite on push and pull request - #2
Merged
Conversation
Today's merge (PR #1) landed with a generic "Merge pull request #1 from Movida/template-clean" title and no description, because it was created through GitHub's raw compare-branches page rather than gh pr create --title/--body — the credential this container already uses for plain git push/fetch works, but only gh talks to the PR API. .devcontainer/devcontainer.json adds the github-cli feature so it's there on every rebuild. .claude/settings.json allowlists gh pr create/view/edit and gh auth status, so Claude Code can create and touch up pull requests without prompting once gh is authenticated. Installed by hand for this session too: /usr/bin/gh 2.99.0, matching the path the existing (previously dead) credential.https://github.com .helper config already pointed at. Not done here, and not something this session can do non-interactively: `gh auth login` — it needs a human to open a browser and approve a device code. Left out deliberately: gh pr merge — merging into main stays a human or explicitly-approved action, not a standing allow rule. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
.github/workflows/test.yml runs npm test plus a --dry-run smoke test of the launcher against a throwaway mission on every push and PR, so a regression in framework/bin/ or framework/hooks/ is caught before it reaches a real mission. Still not pushed: gh is now authenticated (Movida account) but its token scopes (admin:public_key, gist, read:org, repo) don't include workflow, so GitHub still rejects this specific file the same way it did before auth. Needs `gh auth refresh -h github.com -s workflow` (one more browser step) before this can go up, on either remote. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/test.yml runs
npm testplus a--dry-runsmoke test of the launcher (framework/bin/holon-spawn.js) against a throwaway mission on every push and pull request, so a regression inframework/bin/orframework/hooks/is caught before it reaches a real mission.Couldn't be included in #1: pushing anything under
.github/workflows/needs theworkflowOAuth scope, which the credential used here didn't have at the time. Same content, now unblocked.