Fix: autocomplete popup must not take editor focus - #19
Closed
saurav-codes wants to merge 1 commit into
Closed
saurav-codes wants to merge 1 commit into
saurav-codes wants to merge 1 commit into
Conversation
Set NoFocus and WA_ShowWithoutActivating on the autocomplete popup and its list, remove the explicit focus grab when the list updates, and intercept key presses on the editor component while the popup is visible so navigation keys still operate the list. Fixes Mudlet/Mudlet#5310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
The autocomplete popup called setFocus on its list on every update; on some systems (reported on Windows) this moves keyboard focus away from the editor so further typing is blocked.
This sets Qt::NoFocus and WA_ShowWithoutActivating on the popup and list, removes the explicit focus grab, and intercepts editor key presses while the popup is visible so Up/Down/PageUp/PageDown still navigate the list and Enter/Tab/Escape work as before.
References
Fixes Mudlet/Mudlet#5310
Assisted-by: Grok Build:grok