MIR-1657 Make integration tests extensible for downstream applications - #1492
Open
maria-tn wants to merge 7 commits into
Open
Conversation
toKrause
changed the title
rsteph-de
reviewed
Aug 18, 2026
toKrause
changed the title
golsch
requested changes
Aug 18, 2026
| package org.mycore.mir.it.model; | ||
|
|
||
| public enum MIRInstitutes { | ||
| public enum MIRInstitutes implements MIRSampleInstitutes { |
Member
There was a problem hiding this comment.
This is a concrete implementation. The interface should rather be called MIRInstitutes, and the enum should then be called MIRSampleInstitutes.
|
|
||
| import org.mycore.common.selenium.drivers.MCRWebdriverWrapper; | ||
|
|
||
| public class MIRControllerFactory { |
Member
There was a problem hiding this comment.
Shouldn’t appURL and driver be better passed through the constructor here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to jira.