MCR-3811 Create mycore-vue module with shared toolchain and MCRVueRootServlet - #1493
Open
sebhofmann wants to merge 1 commit into
Conversation
…tServlet MCRVueRootServlet moved from org.mycore.webtools.vue to org.mycore.frontend.vue in MyCoRe and is now shipped by the new mycore-vue module. Update the servlet-class of the AccessKeyManager servlet accordingly, which otherwise fails with a ClassNotFoundException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to jira.
Depends on
This PR must not be merged before the MyCoRe PR above is merged, otherwise the referenced class does not exist.
What does this PR do?
MCRVueRootServletwas moved fromorg.mycore.webtools.vuetoorg.mycore.frontend.vuein MyCoRe and is now shipped by the newmycore-vuemodule. Theservlet-classof theAccessKeyManagerservlet inmir-module/src/main/resources/META-INF/web-fragment.xmlis updated accordingly, which otherwise fails with aClassNotFoundException.