Update inactive_clients list and apply it on startup - #880
Open
EvanDietzMorris wants to merge 1 commit into
Open
Update inactive_clients list and apply it on startup#880EvanDietzMorris wants to merge 1 commit into
EvanDietzMorris wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn off all non-shepherd ARAs and KPs
Only the three shepherd ARAs (shepherd-aragorn, shepherd-arax, shepherd-bte) should receive queries going forward.
This adds the other 16 inforesids to inactive_clients in config/config.yaml, and fixes bug-ish behavior that made those entries not be applied for existing django databases even when the app is redeployed.
Specifically,
get_or_create_actorsetactor.active = Falsefor anything in inactive_clients, but only called save() if the actor's inforesid or channel had also changed. For actors already in the database the flag was never persisted. It now saves on its own whenever the flag differs from the config, in both directions, so removing an entry re-activates that actor on the next restart.This also cleans up some leftover old entries (infores:aragorn-ranker-exp, infores:tr_ara_ncats, infores:tr_ara_wfr) which did nothing because they didn't have corresponding entries in httpclients.
The now-disabled services are intentionally left in httpclients; that block holds their endpoint style and params, so re-enabling one is easy (remove it from the inactive list).