Sens.positions.effective.times - #1362
Open
covesturtevant wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the sensor_positions.csv publication metadata to always include effective start/end timestamps and corrects reference-location handling so rows reflect the appropriate reference geolocation over time (rather than always using the first reference geolocation).
Changes:
- Always emit
effectiveStartDateTime/effectiveEndDateTimecolumns and populate them from the intersection of sensor and reference geolocation validity windows. - Fix reference location coordinate selection so each emitted row uses the coordinates from the reference geolocation in effect for that row.
- Expand unit tests to cover overlap behavior, multiple independent geolocation changes, and correct coordinate selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/pub_files/tests/sensor_positions_file/test_sensor_positions_file.py | Updates/extends tests to validate new effective-date columns, overlap filtering, and reference-geolocation coordinate correctness. |
| modules/pub_files/output_files/sensor_positions/sensor_specific_processors.py | Removes the old “blank effective columns” flag and always includes effective dates in tchain rows. |
| modules/pub_files/output_files/sensor_positions/sensor_positions_file.py | Always writes the expanded header, computes effective windows, uses per-geolocation reference coordinates, and sorts output rows by HOR.VER + effective start. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…rove failure logic for malformed geometry.
…EONScience/NEON-IS-data-processing into sens.positions.effective.times
burlingamet
previously approved these changes
Aug 18, 2026
Contributor
Author
|
This PR is on hold for merging, awaiting updates to neonUtilities to handle the new columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add effective start and end times to the sensor positions file in the publication metadata. Also fix bug that used only the first reference geolocation rather than the full reference location history. This bug had not yet impacted any published data.
Tested successfully in pachy-dev with the following data products (added fictitious sensor and reference location moves in INT):
DP1.00094.001 (Soil water content) - sensor-specific processing
DP1.20264.001 (Temp specific depths) - sensor-specific processing
DP1.00045.001 (tipping bucket precip)
DP1.00046.001 (throughfall precip)