Fix trace deletion endpoint to validate successful deletion (Issue #155) - #165
Open
anshul23102 wants to merge 1 commit into
Open
Fix trace deletion endpoint to validate successful deletion (Issue #155)#165anshul23102 wants to merge 1 commit into
anshul23102 wants to merge 1 commit into
Conversation
Fixes NEXARA-oss#155 The DELETE /api/traces/{executionId} endpoint previously returned 200 OK without confirming that traces were actually deleted from the database. This masked silent failures and violated GDPR compliance requirements. Changes: - Added deleteTrace() method to PulseInfra class with proper row count validation - Added trace:write permission to RBAC system - Added DELETE endpoint in pulse-gateway that requires trace:write permission - Added DELETE handler in pulse-trace service that validates deletion success Now returns 404 if trace does not exist, preventing false success responses that could violate data governance policies.
Contributor
Author
|
Hi @NEXARA-oss team! 👋 I've completed the implementation for Issue #155 (Trace deletion endpoint validation). What's Included✅ Proper database deletion confirmation before returning success For ReviewWhen reviewing, labels that would be valuable for tracking:
Ready for your review! 🚀 Contributed as part of GSSoC 2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The DELETE /api/traces/{executionId} endpoint previously returned 200 OK without confirming that traces were actually deleted from the database. This masked silent failures and violated GDPR compliance requirements for right-to-erasure.
Changes
deleteTrace()method to PulseInfra class with proper row count validationtrace:writepermission to RBAC system for delete operationstrace:writefor DELETE requestsBehavior Changes
Fixes #155
Testing