Sanitize span labels to prevent stored XSS attacks (Issue #151) - #169
Open
anshul23102 wants to merge 1 commit into
Open
Sanitize span labels to prevent stored XSS attacks (Issue #151)#169anshul23102 wants to merge 1 commit into
anshul23102 wants to merge 1 commit into
Conversation
Fixes NEXARA-oss#151 Implements HTML encoding for span names, labels, and error messages before storing in database. Prevents stored XSS attacks where agents can inject malicious JavaScript that executes in dashboard user sessions. Changes: - Added sanitizeHtml() function for HTML entity encoding - Applied sanitization to span name before storage - Applied sanitization to span error field - Applied sanitization to string-type span attributes - Encodes HTML special characters: & < > " ' Security improvements: - Prevents stored XSS attacks from malicious span data - Database stores safe HTML-encoded values - Protects dashboard users from credential theft - Works with existing visualization code The sanitization function encodes HTML entities while preserving readability: <script> becomes <script> in storage and display, preventing execution while maintaining data value for debugging.
Contributor
Author
|
Hi @NEXARA-oss team! 👋 I've implemented the fix for Issue #151 (XSS prevention in span labels). What's Included✅ HTML entity encoding for all user-supplied span data Security Benefits
For ReviewLabels valuable for this contribution:
Ready for your review! 🚀 Contributed as part of GSSoC 2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Span names and labels from agents are stored and rendered without HTML encoding. An attacker who can send traces can inject JavaScript that executes in dashboard user browsers, stealing sessions and credentials.
Changes
Security Impact
✅ Prevents stored XSS on observability dashboard
✅ Protects against malicious span data injection
✅ Prevents session/credential theft via dashboard
✅ Preserves data readability while encoding entities
✅ Defense-in-depth at storage layer (not just rendering)
Implementation
<script>→<script>Fixes #151
Testing