DIG-8646 Improve report signposts and layout - #484
Merged
Conversation
maheshmuralip
requested
a lite review from Copilot
and removed request for
a team
September 7, 2026 14:19
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Signposts can now fail to render for non-leaf nodes despite being computed for all nodes, and the signpost title markup change reduces accessibility by removing heading semantics.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the assessment report rendering (web + PDF) to place “Development resources” (signposts) alongside report content in a more consistent layout, increases bar chart sizing for readability, and bumps the application version to 2.1.7.
Changes:
- Move signpost banner rendering so it appears closer to response content in both Livewire and PDF report templates.
- Adjust signpost banner markup/styling and tweak list styling for embedded guidance content.
- Increase bar chart canvas height calculation and bump version + changelog entry to v2.1.7.
File summaries
| File | Description |
|---|---|
| resources/views/pdf/gotenberg-assessment-report.blade.php | Repositions signpost banner rendering within the Gotenberg PDF report output. |
| resources/views/pdf/assessment-report.blade.php | Repositions signpost banner rendering within the Dompdf PDF report output. |
| resources/views/livewire/assessment-report.blade.php | Moves signpost lookup and renders signpost banners alongside responses in the web report. |
| resources/views/components/signpost/signpost-banner.blade.php | Updates the signpost banner title markup and wraps content for spacing/styling. |
| resources/sass/app.scss | Adds styling override for list items inside signpost guidance content when embedded in bordered lists. |
| resources/js/assessment-report.js | Increases calculated bar chart canvas height to improve chart readability. |
| config/app.php | Bumps app version to 2.1.7. |
| CHANGELOG.md | Adds a v2.1.7 changelog entry dated 07.09.2026. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
maheshmuralip
force-pushed
the
DIG-8646
branch
from
September 8, 2026 09:47
20f07d5 to
b01da81
Compare
This update moves development resources to display with each relevant response in both web and PDF reports, keeping signposts grouped and styled consistently. It also increases chart sizing for better readability and bumps the app version to 2.1.7.
Updates assessment report views (Livewire and PDF variants) to avoid repeating node signposts for every response. Signposts now render once in the first question item when responses exist, and still render for non-leaf nodes outside the question list when no list item is available. Also updates the signpost banner title markup from a `strong` to an `h4` heading for clearer structure and consistent styling.
maheshmuralip
force-pushed
the
DIG-8646
branch
from
September 8, 2026 10:50
b01da81 to
15eeae4
Compare
Adjust chart dataset values so raw scores of 1 render as 1.1 for visibility on scales starting at 1, and add a tooltip callback to display those adjusted points as the original value (1). This preserves readability without changing user-facing scores.
Reduce `MIN_VISIBLE_SCORE` in `assessment-report.js` from 1.1 to 1.02 so very low values remain visible without inflating rendered bar heights as much.
Bump `MIN_VISIBLE_SCORE` in `assessment-report.js` from 1.02 to 1.03 so very low scores remain visibly rendered on radar charts while tooltip values stay unchanged.
Updated the assessment report views (Livewire and both PDF templates) to show each response label from `question.node.name` instead of `question.title`. This aligns the displayed heading with node-based naming across output formats, with null-safe access in the Livewire view.
Android63
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update moves development resources to display with each relevant response in both web and PDF reports, keeping signposts grouped and styled consistently. It also increases chart sizing for better readability and bumps the app version to 2.1.7.